feat: add custom params to VertexAIGeminiGenerator and VertexAIGeminiChatGenerator #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:google-vertex
type:documentation
Amnah199
commented
Sep 26, 2024
Comment on lines
+106
to
+112
| self._model = GenerativeModel( | ||
| self._model_name, | ||
| generation_config=self._generation_config, | ||
| safety_settings=self._safety_settings, | ||
| tools=self._tools, | ||
| tool_config=self._tool_config, | ||
| system_instruction=self._system_instruction, |
There was a problem hiding this comment.
Initially, we were passing tools and other parameters directly in the generate_content method. However, these can be passed during model initialization instead, which simplifies parameter handling. See the reference here. This approach simplifies the API's requirement that system_instruction can only be passed during model initialization.
Amnah199
commented
Sep 26, 2024
...s/google_vertex/src/haystack_integrations/components/generators/google_vertex/chat/gemini.py
Show resolved
Hide resolved
julian-risch
requested changes
Sep 26, 2024
...s/google_vertex/src/haystack_integrations/components/generators/google_vertex/chat/gemini.py
Show resolved
Hide resolved
...s/google_vertex/src/haystack_integrations/components/generators/google_vertex/chat/gemini.py
Outdated
Show resolved
Hide resolved
...ations/google_vertex/src/haystack_integrations/components/generators/google_vertex/gemini.py
Outdated
Show resolved
Hide resolved
Amnah199
added a commit
that referenced
this pull request
Oct 2, 2024
…ChatGenerator (#1100) * Added "tool_config" and "system_instruction" params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
tool_configandsystem_instructionparameters to be passed to the model.GenerativeModel(marked in comments).How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.