adding tools to MistralChatGenerator - based on OpenAIChatGenerator #1358
Conversation
github-actions
bot
added
integration:mistral
type:documentation
davidsbatista
requested review from
anakin87 and
vblagoje
and removed request for
a team
| message = results["replies"][0] | ||
|
|
||
| assert message.tool_calls | ||
| tool_call = message.tool_call |
There was a problem hiding this comment.
we discussed about the removal of assert not message.text...
Which kind of text does the model produce along with a tool call?
Is it expected? I can't find it mentioned in [Mistral docs], but I haven't studied the topic in depth.
There was a problem hiding this comment.
There was a problem hiding this comment.
@vblagoje please re-add assert not message.texts here if applicable
|
I asked @davidsbatista to complete this one @anakin87 - he allowed me, should have PR ready by EOD |
...tions/mistral/src/haystack_integrations/components/generators/mistral/chat/chat_generator.py
Show resolved
Hide resolved
| @@ -54,10 +60,11 @@ class MistralChatGenerator(OpenAIChatGenerator): | |||
| def __init__( | |||
| self, | |||
| api_key: Secret = Secret.from_env_var("MISTRAL_API_KEY"), | |||
| model: str = "mistral-tiny", | |||
| model: str = "mistral-small-latest", | |||
There was a problem hiding this comment.
if there is a good reason to change the default model, let's mark this PR as breaking ("!" in the title).
In any case, the title needs to be aligned with the common format.
There was a problem hiding this comment.
ok yeah, will do mark it as breaking, couldn't find this model listed any more nor supporting FC, see https://docs.mistral.ai/capabilities/function_calling/
...tions/mistral/src/haystack_integrations/components/generators/mistral/chat/chat_generator.py
Show resolved
Hide resolved
| message = results["replies"][0] | ||
|
|
||
| assert message.tool_calls | ||
| tool_call = message.tool_call |
There was a problem hiding this comment.
@vblagoje please re-add assert not message.texts here if applicable
| tool_calls.append(ToolCall(id=payload["id"], tool_name=payload["name"], arguments=arguments)) | ||
| except json.JSONDecodeError: | ||
| logger.warning( | ||
| "OpenAI returned a malformed JSON string for tool call arguments. This tool call " |
There was a problem hiding this comment.
| "OpenAI returned a malformed JSON string for tool call arguments. This tool call " | |
| "Mistral returned a malformed JSON string for tool call arguments. This tool call " |
Related Issues
Proposed Changes:
How did you test it?
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.