-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Azure embedders support #6676
Conversation
All yours for tomorrow @anakin87 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good PR!
I found some little opportunities for improvement.
Co-authored-by: Stefano Fiorucci <[email protected]>
Co-authored-by: Stefano Fiorucci <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the tests pass with the suggested changes,
then this PR is good to go!!!
Co-authored-by: Stefano Fiorucci <[email protected]>
Co-authored-by: Stefano Fiorucci <[email protected]>
Why:
Add new embedding components that leverage Azure's cognitive services for text and document embedding. These new components are intended to provide users with more embedding options and utilize Azure's models.
What:
The main changes introduced in the
azure_embedders
branch include:AzureOpenAITextEmbedder
andAzureOpenAIDocumentEmbedder
classes have been added. These are similar to their OpenAI counterparts but use Azure API for embedding texts and documents.__init__.py
: The__init__.py
file within the embedders directory has been modified to include the newly added Azure embedder classes.AzureOpenAITextEmbedder
andAzureOpenAIDocumentEmbedder
to ensure they work as expected and handle various inputs correctly.How can it be used:
The new Azure embedders can be used in the Haystack framework for tasks that involve text and document embedding. Users can utilize these embedders to convert texts or documents into vectors using Azure's cognitive services. This can be particularly useful for tasks involving semantic search, text clustering, or any application that requires understanding the semantic content of texts.
How did you test it:
Notes for the reviewer: