Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: renaming deserialize_document_store_in_init_params_inplace #8379

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: renaming deserialize_document_store_in_init_params_inplace #8379

wants to merge 4 commits into from

Conversation

davidsbatista
Copy link
Contributor

@davidsbatista davidsbatista commented Sep 17, 2024 •
edited
Loading

Proposed Changes:

How did you test it?

  • ran unit tests locally and manual verification
  • ran CI tests

Checklist

@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Sep 17, 2024
@davidsbatista davidsbatista changed the title initial import chore: renaming deserialize_document_store_in_init_params_inplaceuti, it works with any other component Sep 17, 2024
@coveralls
Copy link
Collaborator

coveralls commented Sep 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10907968695

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.388%
Totals Coverage Status
Change from base Build 10904980315: 0.0%
Covered Lines: 7335
Relevant Lines: 8115
💛 - Coveralls

@davidsbatista davidsbatista changed the title chore: renaming deserialize_document_store_in_init_params_inplaceuti, it works with any other component chore: renaming deserialize_document_store_in_init_params_inplace, it works with any other component Sep 17, 2024
@davidsbatista davidsbatista changed the title chore: renaming deserialize_document_store_in_init_params_inplace, it works with any other component chore: renaming deserialize_document_store_in_init_params_inplace Sep 17, 2024
@davidsbatista davidsbatista marked this pull request as ready for review September 17, 2024 17:23
@davidsbatista davidsbatista requested review from a team as code owners September 17, 2024 17:23
@davidsbatista davidsbatista requested review from dfokina, vblagoje and shadeMe and removed request for a team September 17, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

@vblagoje vblagoje Awaiting requested review from vblagoje vblagoje is a code owner automatically assigned from deepset-ai/open-source-engineering

@shadeMe shadeMe Awaiting requested review from shadeMe

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidsbatista @coveralls