Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default_headers for azure embeddings #8535

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nuernber
Copy link

Related Issues

Proposed Changes:

Follows the logic from AzureOpenAIGenerator for default_headers:

default_headers: Optional[Dict[str, str]] = None,

and
default_headers=self.default_headers,

How did you test it?

Ran the unit tests and also tested with my Azure set up that uses a subscription key.

Notes for the reviewer

Checklist

@nuernber nuernber requested review from a team as code owners November 12, 2024 03:37
@nuernber nuernber requested review from dfokina and Amnah199 and removed request for a team November 12, 2024 03:37
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Benjamin Nuernberger seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support default_headers for AzureOpenAIDocumentEmbedder and AzureOpenAITextEmbedder
2 participants