deps: Update govuk-frontend to version 4.5.0 #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpveooys
force-pushed
the
deps/govuk-frontend
branch
2 times, most recently
from
e9a45ef
to
95250cd
Compare
This updates govuk-frontend to version 4.5.0. The new version includes summary cards. Unfortunately Chromium and Firefox have slightly different handling of `hidden="until-found"` (now used in the accordion), which required some tweaks to tests. (Chromium considers those elements as part of the accessibility tree, while other browsers don't seem to.)
jpveooys
force-pushed
the
deps/govuk-frontend
branch
from
95250cd
to
63a77fb
Compare
| @@ -4,6 +4,10 @@ import { expect, test } from '../fixtures' | |||
| // There are various known failures in the GOV.UK Design System: | |||
| // https://github.com/alphagov/govuk-frontend/issues/1280#issuecomment-509588851 | |||
| const DISABLED_RULES: Record<string, Record<string, string[]>> = { | |||
| accordion: { | |||
| default: ['aria-allowed-attr'], | |||
| 'with-summary-lines': ['aria-allowed-attr'], | |||
There was a problem hiding this comment.
I would add a comment because the issue is not included in the known issues link alphagov/govuk-frontend#1280 (comment)
There was a problem hiding this comment.
It does have its own issue it seems alphagov/govuk-frontend#2472
adamledwards
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates govuk-frontend to version 4.5.0. The new version includes summary cards.
Unfortunately Chromium and Firefox have slightly different handling of
hidden="until-found"(now used in the accordion), which required some tweaks to tests. (Chromium considers those elements as part of the accessibility tree, while other browsers don't as they haven't implemented support forhidden="until-found".)