Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http2 Watch has memory issue #424

Closed
cmwylie19 opened this issue Oct 15, 2024 · 1 comment · Fixed by #425
Closed

Http2 Watch has memory issue #424

cmwylie19 opened this issue Oct 15, 2024 · 1 comment · Fixed by #425
Assignees
@cmwylie19
Labels
released

Comments

@cmwylie19
Copy link
Contributor

Describe what should be investigated or refactored

While the http2 what seems to fix our watch issues, it runs very high on memory. There documented issues around http2. In our case, we wanted to get the fix out ASAP as users were manually rolling the watch pod periodically to make the watch react to changes. However, we think we can improve the memory consumption around the http2 watch.

Links to any relevant code

src/fluent/watch.ts http2Watch

Additional context
@cmwylie19 cmwylie19 mentioned this issue Oct 16, 2024
Merged
5 tasks
@cmwylie19 cmwylie19 moved this from 🆕 New to 👀 In review in Pepr Project Board Oct 16, 2024
@cmwylie19 cmwylie19 self-assigned this Oct 16, 2024
btlghrants pushed a commit that referenced this issue Oct 17, 2024
@cmwylie19
fix: reduce memory footprint and refactor (#425)
2f0fb7b 
## Description

Reduces the memory footprint of http2Watch and includes refactoring

Soak Test:
https://github.com/defenseunicorns/pepr/actions/runs/11355812600/job/31585909300

## Related Issue

Fixes #424 

<!-- or -->

Relates to #

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed

Signed-off-by: Case Wylie <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Pepr Project Board Oct 17, 2024
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 3.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmwylie19 cmwylie19

Labels
released
Projects
Pepr Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reduce memory footprint and refactor defenseunicorns/kubernetes-fluent-client
1 participant
@cmwylie19