fix: Remove spaces from IAM policy sids #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses an issue discovered with spaces in SIDs, which was identified after the terraform AWS provider update to version 5.82.0 introduced additional validation. The update caused errors due to invalid SIDs containing spaces, as SIDs must not contain spaces according to [AWS IAM policy documentation]. The additional validation added in 5.82.0 has since been reverted (it caused additional issues, see: hashicorp/terraform-provider-aws#40639) and 5.82.1 was released without the validation. However it brought to light that spaces are not allowed in IAM Policy Document SIDs. Ref: (https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_elements_sid.html).
Changes Made
References