Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove spaces from IAM policy sids #33

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jasonwashburn
Copy link

Summary

This PR addresses an issue discovered with spaces in SIDs, which was identified after the terraform AWS provider update to version 5.82.0 introduced additional validation. The update caused errors due to invalid SIDs containing spaces, as SIDs must not contain spaces according to [AWS IAM policy documentation]. The additional validation added in 5.82.0 has since been reverted (it caused additional issues, see: hashicorp/terraform-provider-aws#40639) and 5.82.1 was released without the validation. However it brought to light that spaces are not allowed in IAM Policy Document SIDs. Ref: (https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_elements_sid.html).

Changes Made

  • Removed spaces from SIDs to comply with AWS formatting rules for IAM policy documents.

References

@jasonwashburn jasonwashburn force-pushed the fix/remove-spaces-from-iam-policy-sids branch from 3938472 to 7149a81 Compare December 20, 2024 17:44
@jasonwashburn
Copy link
Author

Seems that tflint workflow is failing because terraform-docs isn't configured to ignore lockfiles. When it's not configured to ignore lockfiles and there's no file checked in, it will cause a version update in the output based on whatever the CI runner has installed at runtime rather than just documenting the actual requirement like >= 4.62.0. See excerpt from https://terraform-docs.io/user-guide/configuration/settings/#examples
image

Added --lockfile=false to args to get CI passing as I assume this is not the desired behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants