Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: omit .secret field, set app password in advance #33

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

chaospuppy
Copy link

@chaospuppy chaospuppy commented Nov 22, 2024

Description

This PR will allow users to specify an app password in advance, or default to a random password if a password is not provided. Additionally, because the reuse of an existing secret was taking precedence over the random password (to avoid changing the secret every time you deploy), we check to see if a password has not been provided and there is an existing secret, in which case the password will not change between deployments.

Lastly, the top-level .secrets key is deprecated, but is left in the upstream chart, resulting in a pointless example secret called myminio-env-configuration being created which made troubleshooting more confusing.

Related Issue

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@chaospuppy chaospuppy requested a review from a team as a code owner November 22, 2024 22:19
@chaospuppy chaospuppy changed the title omit deprecated .secret field, allow for setting of app password in advance, do not reuse existing secret omit deprecated .secret field, allow for setting of app password in advance, do not reuse secret Nov 22, 2024
@chaospuppy chaospuppy changed the title omit deprecated .secret field, allow for setting of app password in advance, do not reuse secret update: omit .secret field, allow for setting app password in advance, do not reuse secret Nov 22, 2024
@chaospuppy chaospuppy changed the title update: omit .secret field, allow for setting app password in advance, do not reuse secret update: omit .secret field, set app password in advance Nov 22, 2024
@chaospuppy chaospuppy changed the title update: omit .secret field, set app password in advance feat: omit .secret field, set app password in advance Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant