feat: omit .secret field, set app password in advance #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will allow users to specify an app password in advance, or default to a random password if a password is not provided. Additionally, because the reuse of an existing secret was taking precedence over the random password (to avoid changing the secret every time you deploy), we check to see if a password has not been provided and there is an existing secret, in which case the password will not change between deployments.
Lastly, the top-level
.secrets
key is deprecated, but is left in the upstream chart, resulting in a pointless example secret calledmyminio-env-configuration
being created which made troubleshooting more confusing.Related Issue
Type of change
Checklist before merging