Skip to content

Commit

Permalink
chore: update custom network properties key (#147)
Browse files Browse the repository at this point in the history
## Description

- Updating all instances of custom: [] to additionalNetworkAllow: []

## Related Issue

Fixes #
<!-- or -->
Relates to #

https://github.com/orgs/defenseunicorns/projects/118/views/12?pane=issue&itemId=87152090&issue=defenseunicorns%7Cuds-package-maintenance%7C5
## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-package-gitlab/blob/main/CONTRIBUTING.md#developer-workflow)
followed
  • Loading branch information
codyshoffner authored Dec 10, 2024
1 parent e82a5e3 commit ddff85a
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 6 deletions.
2 changes: 1 addition & 1 deletion chart/templates/uds-package.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ spec:
description: "CE Bean Monitor"

# Custom rules for unanticipated scenarios
{{- range .Values.custom }}
{{- range .Values.additionalNetworkAllow }}
- direction: {{ .direction }}
selector:
{{ .selector | toYaml | nindent 10 }}
Expand Down
2 changes: 1 addition & 1 deletion chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ postgres:
cluster-name: pg-cluster
namespace: postgres
port: 5432
custom: []
additionalNetworkAllow: []
# # Notice no `remoteGenerated` field here on custom internal rule
# - direction: Ingress
# selector:
Expand Down
2 changes: 1 addition & 1 deletion docs/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ SonarQube in this package is configured through the upstream [SonarQube chart](h
Network policies are controlled via the `uds-sonarqube-config` chart in accordance with the [common patterns for networking within UDS Software Factory](https://github.com/defenseunicorns/uds-software-factory/blob/main/docs/networking.md). SonarQube interacts with Postgresql externally and supports the following keys:

- `postgres`: sets network policies for accessing a Postgres database from the SonarQube pod
- `custom`: sets custom network policies for the SonarQube namespace - this allows for custom integrations with other services
- `additionalNetworkAllow`: sets custom network policies for the SonarQube namespace - this allows for custom integrations with other services

## Database

Expand Down
3 changes: 0 additions & 3 deletions tasks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
# SPDX-License-Identifier: AGPL-3.0-or-later OR LicenseRef-Defense-Unicorns-Commercial

includes:
- dependencies: ./tasks/dependencies.yaml
- test: ./tasks/test.yaml
- create: https://raw.githubusercontent.com/defenseunicorns/uds-common/v1.4.0/tasks/create.yaml
- publish: https://raw.githubusercontent.com/defenseunicorns/uds-common/v1.4.0/tasks/publish.yaml
Expand Down Expand Up @@ -59,8 +58,6 @@ tasks:
description: Test an upgrade from the latest released package to the current branch
actions:
- task: upgrade:create-latest-tag-bundle
with:
dep_commands: ./uds run dependencies:create
- task: setup:k3d-test-cluster
- task: deploy:test-bundle
- task: setup:create-doug-user
Expand Down

0 comments on commit ddff85a

Please sign in to comment.