Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zarf agent mutating webhook #306

Merged
merged 42 commits into from
May 19, 2022
Merged

Zarf agent mutating webhook #306

merged 42 commits into from
May 19, 2022

Conversation

jeff-mccoy
Copy link
Contributor

Initial mutating webhook work.

@jeff-mccoy jeff-mccoy marked this pull request as draft February 9, 2022 12:47
@YrrepNoj YrrepNoj self-requested a review February 9, 2022 14:15
@RothAndrew
Copy link
Contributor

Is this the highest priority right now? I thought we were going to be spending time making the testing and documentation more robust and paying down tech debt now that the big PR is merged. This feels like jumping right back to feature development.

@RothAndrew
Copy link
Contributor

Before we get too far we also need to get an issue written up in the backlog for this work so we can have a clear idea on when the Definition of Done is met and it can be merged.

@jeff-mccoy
Copy link
Contributor Author

I'm not working this week due to Covid, so this is how I am spending my time. And yes it is important to resolve unfinished work around the new postRender behavior and operators / Big Bang. We discussed before the bandaid of manually patching image repos in Big Bang and fixing it right after #237 was merged, this is that fix.

@RothAndrew
Copy link
Contributor

I'm not working this week due to Covid, so this is how I am spending my time. And yes it is important to resolve unfinished work around the new postRender behavior and operators / Big Bang. We discussed before the bandaid of manually patching image repos in Big Bang and fixing it right after #237 was merged, this is that fix.

Copy. That makes sense. Can we get together and write out a new GitHub issue for this? It will help us keep the scope small.

@jeff-mccoy
Copy link
Contributor Author

Yeah for sure, I'll ping you later today if you're free. I was going through old issues last night but still need to make new issues for things we didn't get into #237 that will be needed or desired to fully realize everything that #237 provided.

@jeff-mccoy jeff-mccoy self-assigned this Feb 9, 2022
@jeff-mccoy jeff-mccoy linked an issue Feb 16, 2022 that may be closed by this pull request
Consistently apply secrets & image mutations #334
Closed
@jeff-mccoy jeff-mccoy added adr-required enhancement ✨ New feature or request needs-docs PR Label - Docs required to merge labels Feb 26, 2022
@jeff-mccoy jeff-mccoy force-pushed the zarf-agent branch 3 times, most recently from 1b3ea6a to b8d2e1a Compare May 17, 2022 09:29
@jeff-mccoy
Copy link
Contributor Author

I plan on testing this on the s/w factory repo once it's happy in BB core example. Things are mostly working, but I ran into a possible new issue for maybe @YrrepNoj to look at with the gitea read only user. The 2 sandbox repos seem to be unable to add read only users for some reason....

Screen Shot 2022-05-17 at 4 56 37 AM

Screen Shot 2022-05-17 at 4 59 34 AM

Screen Shot 2022-05-17 at 4 58 45 AM

Screen Shot 2022-05-17 at 4 59 51 AM

YrrepNoj
YrrepNoj reviewed May 17, 2022
View reviewed changes
src/Makefile Outdated Show resolved Hide resolved
src/config/config.go Show resolved Hide resolved
src/internal/images/push.go Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
src/internal/agent/start.go Show resolved Hide resolved
src/internal/agent/operations/patch.go Show resolved Hide resolved
packages/zarf-agent/zarf.yaml Outdated Show resolved Hide resolved
@jeff-mccoy
Copy link
Contributor Author

BB Core on 1.33 w/Loki vs EFK is happy w/Zarf agent.

Screen Shot 2022-05-17 at 6 47 21 PM

Screen Shot 2022-05-17 at 6 47 34 PM

@jeff-mccoy jeff-mccoy added k8s and removed needs-adr labels May 18, 2022
YrrepNoj
YrrepNoj previously approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes and updates look good to me 👍

@jeff-mccoy
Copy link
Contributor Author

We have a winner. Fixed the fun BB issue with the gatekeeper.

Screen Shot 2022-05-19 at 1 11 26 AM

YrrepNoj
YrrepNoj approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking up and updating on the gatekeeper stuff. LGTM!

@jeff-mccoy jeff-mccoy merged commit fdaff86 into master May 19, 2022
@jeff-mccoy jeff-mccoy deleted the zarf-agent branch May 19, 2022 07:07
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
@jeff-mccoy @YrrepNoj
Zarf Agent mutating webhook (#306)
e124297 
- Introduce mutating webhook (zarf agent)
- Mutate podSpec image paths 
- Mutate podSpec imagePullSecret
- Mutate Flux GitRepository URL
- Mutate Flux GitRepository secret

- Add dev makefile targets for image rebuilds
- Add manual github action for building a new zarf agent image

- Update Big Bang example package 1.28 -> 1.33
- Migrate EFK -> PLG for Big Bang example
- Fix OPA Gatekeeper failures on KIND clusters

- Add Zarf Agent ADR

Co-authored-by: Jon Perry <[email protected]>
@cmwylie19 cmwylie19 mentioned this pull request Jun 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RothAndrew RothAndrew RothAndrew left review comments

@YrrepNoj YrrepNoj YrrepNoj approved these changes

Assignees

@jeff-mccoy jeff-mccoy

Labels
enhancement ✨ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistently apply secrets & image mutations
3 participants
@jeff-mccoy @RothAndrew @YrrepNoj