Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'fiddle' gem as a runtime dependency #852

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add 'fiddle' gem as a runtime dependency #852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ PATH
remote: .
specs:
byebug (11.1.3)
fiddle (~> 1.0)

GEM
remote: https://rubygems.org/
Expand All @@ -15,6 +16,7 @@ GEM
docile (1.3.4)
faraday (1.0.0)
multipart-post (>= 1.2, < 3)
fiddle (1.1.2)
method_source (1.0.0)
minitest (5.14.4)
multipart-post (2.1.1)
Expand Down
2 changes: 2 additions & 0 deletions byebug.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,7 @@ Gem::Specification.new do |s|
s.extensions = ["ext/byebug/extconf.rb"]
s.require_path = "lib"

s.add_dependency "fiddle", "~> 1.0"
Copy link
Author

@davidrunger davidrunger Sep 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It definitely feels kind of sad to be taking byebug from being a dependency-free gem to now having a runtime dependency, but I guess that unfortunately that might sort of be the inevitable result of Ruby moving more and more of its non-core functionality out of the standard library and into gems.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure which version specifier to put here. I went with ~> 1.0 because:

  1. fiddle v1.0.0 was released quite a while ago, on 2017-12-06 (source).
  2. That ensures that we will require the latest fiddle major version (i.e. version 1) and that we won't pull in any subsequent major version (e.g. version 2) that might include breaking changes.


s.add_development_dependency "bundler", "~> 2.0"
end