Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric for service backend counts #305

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Drahflow
Copy link
Contributor

@Drahflow Drahflow commented Mar 1, 2016

No description provided.

@emulbreh
Copy link
Contributor

emulbreh commented Mar 1, 2016

This is almost definitely the wrong place to do this. If you just want a global instance count you should add it to lymph-monitor.

@Drahflow
Copy link
Contributor Author

Drahflow commented Mar 1, 2016

It is a very good place to put it. Because it will report what the various instances believe to be the case -- and this is what needs to be correct (and hence monitored).

@emulbreh
Copy link
Contributor

emulbreh commented Mar 1, 2016

let's rename it to something that communicates this idea then, known_instance_count maybe, with address as a tag.

@Drahflow Drahflow force-pushed the 2016-03-01-service-instances-metric branch from 7ba9bc8 to 1c2daff Compare March 1, 2016 14:02
@emulbreh emulbreh changed the title MAN-35: Add metric for service backend counts Add metric for service backend counts Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants