Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-9575 Add support for additional mount in vsdk/dvp for dSources operations #459

Merged
merged 7 commits into from
Mar 22, 2023

Conversation

SumoSourabh
Copy link
Contributor

@SumoSourabh SumoSourabh commented Mar 3, 2023

Background

Currently, Delphix engine does not support multiple mounts for dSource created by AppData / plugins / select connectors. For cluster based databases, the requirement is to support additional mount points for dSources also.
As part of the changes, mounts is added to staged_source and StagedMountSpecResponse.

Problem

IDEA is to support multiple mounts for Staged sources.

Solution

dvp-api 1.7.1.dev0 is published to TestPyPi which now support mounts in staged_source and StagedMountSpecResponse.

Platform package has been updated to now consume the mounts from staged_source and also set the multiple mounts received from plugin to StagedMountSpecResponse.

Testing Done

Manual Testing

  • added unit test cases to cover all the changes done as part of the solution. Now the test cases for staged source covers single mount, multiple mount and both parameters set in staged_source.
  • Manually Tested the code for older plugins (works fine with single mount point) and also tested with multiple mount points plugins (for newer changes).

Automated Testing
For auomated testing, we are only testing for regression use cases as we are supporting backward compatibility, so older plugins should work fine with the new changes.

@SumoSourabh SumoSourabh changed the title CP-9575 Add support for additional mount in vsdk/dvp for dSources ope… CP-9575 Add support for additional mount in vsdk/dvp for dSources operations Mar 6, 2023
@SumoSourabh SumoSourabh marked this pull request as ready for review March 8, 2023 06:59
@SumoSourabh SumoSourabh requested a review from a team as a code owner March 8, 2023 06:59
@SumoSourabh SumoSourabh merged commit 8a9f174 into delphix:develop Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants