Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reoptimizes merge bins with only 1 file, even though they have no effect. #1901

Closed
haruband opened this issue Nov 24, 2023 · 0 comments · Fixed by #1902
Closed

Reoptimizes merge bins with only 1 file, even though they have no effect. #1901

haruband opened this issue Nov 24, 2023 · 0 comments · Fixed by #1902
Labels
bug Something isn't working

Comments

@haruband
Copy link
Contributor

haruband commented Nov 24, 2023 •
edited
Loading

Environment

Delta-rs version: 0.17.0

Binding: Rust

Environment:

  • Cloud provider:
  • OS: MacOS/Linux
  • Other:

Bug

What happened:
Reoptimizes merge bins with only 1 file, even though they have no effect. This problem only occurs when there are multiple merge bins.

What you expected to happen:
Should not reoptimize merge bins with only 1 file, since they have no effect.

How to reproduce it:

More details:
@haruband haruband added the bug Something isn't working label Nov 24, 2023
@haruband haruband mentioned this issue Nov 24, 2023
Merged
@haruband haruband changed the title Reoptimizes merge bin with only 1 file, even though they have no effect. Reoptimizes merge bins with only 1 file, even though they have no effect. Nov 24, 2023
ion-elgreco pushed a commit that referenced this issue Dec 2, 2023
@haruband
fix: prune each merge bin with only 1 file (#1902)
06109de 
# Description
This PR prunes each merge bin with only 1 file, even though there are
multiple merge bins.

# Related Issue(s)
- closes #1901 

# Documentation
This PR adds test_idempotent_with_multiple_bins() for testing.
Jan-Schweizer pushed a commit to Jan-Schweizer/delta-rs that referenced this issue Dec 2, 2023
@haruband @Jan-Schweizer
fix: prune each merge bin with only 1 file (delta-io#1902)
f90b48c 
# Description
This PR prunes each merge bin with only 1 file, even though there are
multiple merge bins.

# Related Issue(s)
- closes delta-io#1901 

# Documentation
This PR adds test_idempotent_with_multiple_bins() for testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prune each merge bin with only 1 file haruband/delta-rs
1 participant
@haruband