Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error message for parition_by check #2177

Closed
braaannigan opened this issue Feb 9, 2024 · 1 comment · Fixed by #2179
Closed

Add error message for parition_by check #2177

braaannigan opened this issue Feb 9, 2024 · 1 comment · Fixed by #2179
Labels
bug Something isn't working

Comments

@braaannigan
Copy link
Contributor

Great work on this project!

I triggered the assertion error below. However, as there is no string message after the assertion I get no indication of what went wrong from logging

Delta-rs version:
0.15.1

Environment:
MacOS

Bug

What happened:
I hit this assertion check in write_deltalake:

assert partition_by == table.metadata().partition_columns

What you expected to happen:
Produce a string to explain what the error is (and preferably how it might be avoided)
@braaannigan braaannigan added the bug Something isn't working label Feb 9, 2024
@ion-elgreco
Copy link
Collaborator

ion-elgreco commented Feb 9, 2024 •
edited
Loading

@braaannigan if you want you can open a small PR for it? :) I agree, a helpful error message is useful here

@braaannigan braaannigan mentioned this issue Feb 9, 2024
Merged
ion-elgreco pushed a commit that referenced this issue Feb 10, 2024
@braaannigan
feat: add comment to explain why assert has failed and show state (#2179
02fa4c2 
)

# Description
Add comment to explain why assert has failed for partition_by columns
and show state

# Related Issue(s)
 closes #2177

---------

Co-authored-by: Liam Brannigan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add comment to explain why assert has failed and show state braaannigan/delta-rs
2 participants
@braaannigan @ion-elgreco