-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3 object store always returns IMDS warnings #2460
Comments
@ion-elgreco I assume this is manifesting when using the S3 backend outside of the AWS environment? |
Yup! With custom S3 endpoints |
@rtyler actually, also with just aws S3. Forgot that I was seeing that when @mightyshazam and I were chatting about it |
We were debugging it over Slack. We were both running the same code via command line and notebooks, but I wasn't seeing the error while Ion was. Ion's coworkers were also seeing it. We even accounted for potentially different environment variables, but that had no effect. I need more sample data to reproduce it. |
…nd object stores (#2500) The object store changes the keys used for creating the s3 options, while the log store does not. The difference between the two, and their usage together was causing some weird fallback behavior in the AWS SDK that invoked the IMDS service despite explicitly disabling it in multiple places. This fix handles the potentially different casing along with passing the options unmolested. It should stop any future, unwanted, IMDS behavior # Description The description of the main changes of your pull request # Related Issue(s) - closes #2460 # Documentation <!--- Share links to useful documentation ---> --------- Co-authored-by: KyJah Keys <[email protected]>
When using the S3 Object store, it will still try to use the IMDS provider by default, only when setting an environment variable
AWS_EC2_METADATA_DISABLED
, it's not throwing the warnings anymore.@mightyshazam created an issue, so we can track this
The text was updated successfully, but these errors were encountered: