Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project should use the same version of ruff in the lint stage of python_build.yml as in pyproject.toml #2678

Closed
fpgmaas opened this issue Jul 16, 2024 · 1 comment · Fixed by #2679
Closed

Project should use the same version of ruff in the lint stage of python_build.yml as in pyproject.toml #2678

fpgmaas opened this issue Jul 16, 2024 · 1 comment · Fixed by #2679
Assignees
@fpgmaas
Labels
bug Something isn't working

Comments

@fpgmaas
Copy link
Contributor

fpgmaas commented Jul 16, 2024 •
edited
Loading

Bug

What happened:

Currently, the CI/CD pipeline is failing due to a new release of ruff. In this line, the version of ruff is not pinned:

pip install ruff black mypy types-dataclasses typing-extensions

so in the CI/CD pipeline the latest version of ruff is used, but in pyproject.toml it is pinned to an older version. As a result, locally we use a different version than in the CI/CD pipeline.

A short term solution is provided by #2673, but we should probably look into a long term solution:

The options I can think of:

  • pin ruff in the CI/CD pipeline and keep it in sync manually, but a similar issue may pop-up for the other packages there.
  • Instead of installing the dependencies manually, install the project and then run the linters.
@fpgmaas fpgmaas added the bug Something isn't working label Jul 16, 2024
This was referenced Jul 16, 2024
Merged
Merged
Merged
@fpgmaas
Copy link
Contributor Author

fpgmaas commented Jul 16, 2024

take

@fpgmaas fpgmaas mentioned this issue Jul 16, 2024
Merged
rtyler pushed a commit that referenced this issue Jul 18, 2024
@fpgmaas
chore: pin ruff and mypy versions in the lint stage in the CI p…
30bab74 
…ipeline (#2679)

Currently, `ruff` and `mypy` have their latest versions installed in the
CI pipeline, while locally they are fixed to a specific version. This
can cause issues, see #2678.

This PR proposes to fix them to their specific version in the pipeline.
The alternative I could think of was installing the virtual environment
with `make develop`, but that takes between 4 and 5 minutes, which might
be considered a bit too long to wait on linting results.

This PR will have conflicts with
#2674, so I'll need to rebase
one of these PR's once the other is merged.

# Related Issue(s)

- closes [#106](#2678)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fpgmaas fpgmaas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: pin ruff and mypy versions in the lint stage in the CI pipeline fpgmaas/delta-rs
1 participant
@fpgmaas