-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve err msg on use of non-partitioned column #1221
improve err msg on use of non-partitioned column #1221
Conversation
Signed-off-by: Marijn Valk <[email protected]>
Signed-off-by: Marijn Valk <[email protected]>
Signed-off-by: Marijn Valk <[email protected]>
Signed-off-by: Marijn Valk <[email protected]>
rust/src/table_state.rs
Outdated
for f in filters { | ||
if !current_metadata.partition_columns.contains(&f.key.into()) { | ||
let column = f.key.to_string(); | ||
return Err(DeltaTableError::ColumnNotPartitioned { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick, the original implementation returns all columns that aren't partitioned, but this implementation does an early return, which results in a different behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @houqp, good point! I tried to restore to the original behavior in the latest commit
Signed-off-by: Marijn Valk <[email protected]>
Signed-off-by: Marijn Valk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took a bit to get to reading this. Looks good :)
Description
Updates the error message when trying to use a partition filter with a column that is not partitioned.
Code to trigger the error (adapted from #1219):
Related Issue(s)
closes #1218
Documentation