feat: write command improvements #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
roeap
force-pushed
the
write-command
branch
2 times, most recently
from
86513e6 to
d64c475
Compare
roeap
changed the title
roeap
requested review from
houqp,
xianwill,
wjones127,
fvaleye,
rtyler and
mosyp
as code owners
rtyler
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the write operation, specifically:
One potentially more controversial change is that we now try to case all batches written to either the physical schema (derived from latest parquet file) or the schema derived from the table. I feel this logic may eventually need some updating or at least we need to make sure this is consistently handled across all write paths. In any case, using the file schema we dis already see some schema mis-matches in current tests, so that I included some casting for record batches here.
Related Issue(s)
Documentation