fix: add sizeInBytes to _last_checkpoint and change size to # of actions
#1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
cmackenzie1
requested review from
houqp,
xianwill,
wjones127,
fvaleye,
roeap,
rtyler and
mosyp
as code owners
wjones127
previously approved these changes
Jun 20, 2023
wjones127
changed the title
sizeInBytes to _last_checkpoint and change size to # of actionssizeInBytes to _last_checkpoint and change size to # of actions
wjones127
reviewed
Jun 20, 2023
cmackenzie1
commented
Jun 20, 2023
rust/src/action/mod.rs
Outdated
| size: 0, | ||
| parts: None, | ||
| }); | ||
| cp = Some(CheckPoint::new(version, 0, None)); |
There was a problem hiding this comment.
@wjones127 this was the culprit. Fixing...
Suggested change
| cp = Some(CheckPoint::new(version, 0, None)); | |
| cp = Some(CheckPoint::new(curr_ver, 0, None)); |
…actions The `size` field should be the number of actions stored in the checkpoint while `sizeInBytes` is used for the total size in bytes. Added `CheckPointBuilder` to make the creation of these easier to use. - Closes delta-io#1468
cmackenzie1
force-pushed
the
cole/issue-1468
branch
from
152800a to
f58e2a0
Compare
wjones127
approved these changes
Jun 20, 2023
|
Thanks @cmackenzie1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
sizefield should be the number of actions stored in the checkpoint whilesizeInBytesis used for the total size in bytes.Added
CheckPointBuilderto make the creation of these easier to use.Related Issue(s)
Documentation
https://github.com/delta-io/delta/blob/master/PROTOCOL.md#last-checkpoint-file