refactor: clean up arrow schema defs #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds some helper macros for defining Arrow schemas. The goal is to improve readability and reduce repetition so that modifying these definitions is less error prone.
polynomialherder
requested review from
houqp,
xianwill,
wjones127,
fvaleye,
roeap,
rtyler and
mosyp
as code owners
roeap
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Arrow schema definitions in
delta_log_schema_for_tableare currently a bit tricky to read -- it's not straightforward to tell from looking at, say, this line to which field that particulartruebelongs. This adds a few helper macros that hopefully make this a little more readable, and replaces the existing definitions with calls to those macros that result in equivalent code.These macros are fairly tailored to these specific schema definitions, so I just included them in the delta_arrow module, but happy to break them off into their own module and include tests for them. I mostly wanted to see if this sort of a refactor would be welcome given that I've seen discussion about moving away from using Arrow internally over the long term (?)