-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't re-encode paths #1613
Conversation
f9a1220
to
279ff4c
Compare
This also resolves the issue in #1228 based on my testing. |
Testing with 0.10.2 i could still reproduce the issue #1391
|
yep, same problem here |
@ABChristian Thanks for testing. I'll take a look at that soon. |
Using 0.10.2, I'm having this same issue where Windows paths cannot be decoded due to their spaceyness. Writing only succeeds where paths which have no space characters. :( |
Using 0.16.4 I am having same issue. Running Python code from a path that contains spaces gives me 'object at location <FILL PATH WITH SPACES that have been replaced with %20 .... parquet file> not found .... Read Data from Delta tabledt.to_pandas() |
Quickstart on Homepage results in error in reading (writing part goes ok), same issue as my previous post. |
Description
In the delta log, paths are percent encoded. We decode them here:
delta-rs/rust/src/action/mod.rs
Lines 435 to 437 in 787c13a
Which is good. But then we've been re-encoding them with
Path::from
. This PR changes to usePath::parse
when possible instead. Instead of propagating errors, we just fallback toPath::from
for now. Read more here: https://docs.rs/object_store/0.7.0/object_store/path/struct.Path.html#encodeRelated Issue(s)
Documentation