fix: respect case sensitivity on operations #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Blajda this seems reasonable to me, are you ready to pull it out of draft? |
ion-elgreco
approved these changes
Dec 12, 2023
rtyler
approved these changes
Dec 12, 2023
|
@Blajda since you contributed this fix, is this an urgent thing you would like to depend on (i.e. I need to backport to the 0.16 release branch) or are you okay with it going out in 0.17 in a few weeks? |
|
I'm okay with this going out in 0.17. Thanks! |
|
Is there any update on this? This issue is currently blocking us on implementing the merge features in delta-rs |
|
@cesar-vermeulen which version are you using? because this is already released |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default when Datafusion parses sql expressions it converts columns references to lower case. The
Intotrait forColumnwill also convert the column name to lower case. This is an issue since column names are case sensitive in the delta protocol and it has prevented users from using various operation with the python bindings.This is fixed by configuring Datafusion's sql parser to not normalize identifiers and any public references to
Columnare replaced withDeltaColumnwhich will keep capitalization.Related Issue(s)