Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flakey gcs test #1987

Merged
merged 1 commit into from
Dec 20, 2023
Merged

fix: flakey gcs test #1987

merged 1 commit into from
Dec 20, 2023

Conversation

roeap
Copy link
Collaborator

@roeap roeap commented Dec 20, 2023

Description

The GCS tests seem to be failing sometimes, looked around and hoping this change fixes that.

@github-actions github-actions bot added binding/rust Issues for the Rust crate crate/core labels Dec 20, 2023
@roeap roeap enabled auto-merge (squash) December 20, 2023 09:24
@roeap
Copy link
Collaborator Author

roeap commented Dec 20, 2023

@ion-elgreco - any chance you could approve this really quick?

ion-elgreco
ion-elgreco approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@ion-elgreco ion-elgreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ofcourse:)

@roeap roeap changed the title fix: flaky gcs test fix: flakey gcs test Dec 20, 2023
@roeap roeap merged commit c14d577 into delta-io:main Dec 20, 2023
21 checks passed
@roeap roeap deleted the flaky-ci-gcs branch December 20, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ion-elgreco ion-elgreco ion-elgreco approved these changes

@wjones127 wjones127 Awaiting requested review from wjones127 wjones127 is a code owner

@rtyler rtyler Awaiting requested review from rtyler rtyler is a code owner

Assignees
No one assigned
Labels
binding/rust Issues for the Rust crate crate/core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roeap @ion-elgreco