fix: ensure metadata cleanup do not corrupt tables without checkpoints #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If there is a desire to refactor this operation into |
|
@Blajda maybe let's get the fix in first depending on how much time it takes to make it a DeltaOps, this seems quite severe, so we ideally should push a release soon |
Yes I think that's the best approach for this. |
Blajda
requested review from
wjones127,
fvaleye,
roeap,
ion-elgreco and
rtyler
as code owners
ion-elgreco
reviewed
Jan 7, 2024
There was a problem hiding this comment.
@Blajda could you add one more python test to cover the case where no checkpoint is added?
ion-elgreco
approved these changes
Jan 7, 2024
r3stl355
pushed a commit
to r3stl355/delta-rs
that referenced
this pull request
Jan 10, 2024
delta-io#2044) # Description When metadata cleanup is executed on a delta table without checkpoints it will corrupt the table and prevent further loading. This is a high risk for people who use delta-rs since our writers do not automatically create checkpoints. # Related Issue(s) - closes delta-io#2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When metadata cleanup is executed on a delta table without checkpoints it will corrupt the table and prevent further loading. This is a high risk for people who use delta-rs since our writers do not automatically create checkpoints.
Related Issue(s)