Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add dask page to integration docs #2122

Merged
merged 4 commits into from
Jan 27, 2024
Merged

docs: add dask page to integration docs #2122

merged 4 commits into from
Jan 27, 2024

Conversation

avriiil
Copy link
Contributor

@avriiil avriiil commented Jan 26, 2024 •
edited
Loading

No description provided.

@avriiil avriiil requested a review from MrPowers as a code owner January 26, 2024 14:32
@github-actions GitHub Actions
Copy link

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@avriiil avriiil changed the title Add Dask to Integration docs docs: Add Dask page to Integration docs Jan 26, 2024
@avriiil avriiil changed the title docs: Add Dask page to Integration docs docs: add dask page to integration docs Jan 26, 2024
MrPowers
MrPowers approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@MrPowers MrPowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ion-elgreco
Copy link
Collaborator

@MrPowers do we want to show that in our docs?

It seems dask-deltalake hasn't been updated for over 6 months and relies on an older python version of deltalake

@MrPowers
Copy link
Contributor

@ion-elgreco - yea, I think it's good to highlight.

Does it depend on a specific version of deltalake? Here's the dependency I could spot: https://github.com/dask-contrib/dask-deltatable/blob/main/requirements.txt#L2

@ion-elgreco
Copy link
Collaborator

ion-elgreco commented Jan 26, 2024 •
edited
Loading

@MrPowers well it doesn't depend but our new releases broke their package since they are using private methods, which ofcourse is at someone's own risk :)

@MrPowers
Copy link
Contributor

@ion-elgreco - yep, well we should help them make fixes I think 😄

I kind of view us as being responsible for the whole Delta Lake ecosystem that depends on delta-rs too.

@ion-elgreco ion-elgreco enabled auto-merge (squash) January 27, 2024 10:57
@ion-elgreco ion-elgreco merged commit 603a81e into delta-io:main Jan 27, 2024
23 checks passed
@roeap roeap mentioned this pull request Jan 27, 2024
Closed
RobinLin666 pushed a commit to RobinLin666/delta-rs that referenced this pull request Feb 2, 2024
@avriiil @ion-elgreco @RobinLin666
docs: add dask page to integration docs (delta-io#2122)
b0fad65 
Co-authored-by: Ion Koutsouris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrPowers MrPowers MrPowers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avriiil @ion-elgreco @MrPowers