Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2143): keep specific error type when writing fails #2144

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

abaerptc
Copy link
Contributor

@abaerptc abaerptc commented Jan 29, 2024

Description

Add case to error conversion implementation to preserve structured parsing error instead of converting to plain string.

Related Issue(s)

@github-actions github-actions bot added binding/rust Issues for the Rust crate crate/core labels Jan 29, 2024
Copy link

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@abaerptc abaerptc changed the title fix(#2143): Keep specific error type when writing fails. fix(#2143): keep specific error type when writing fails Jan 29, 2024
@rtyler
Copy link
Member

rtyler commented Jan 29, 2024

Thanks for the pull request @abaerptc, unfortunately I just dropped some folder renames into main, would you mind rebasing please?

@rtyler rtyler merged commit dcbfb62 into delta-io:main Jan 29, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JsonWriter converts structured parsing error into plain string
2 participants