fix(python, rust): use from_name during column projection creation #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion-elgreco
requested review from
wjones127,
fvaleye,
roeap and
rtyler
as code owners
ion-elgreco
force-pushed
the
fix/merge_special_characters_name_lost
branch
from
10fe7e5 to
b6aa98b
Compare
github-actions
bot
added
binding/python
…ub.com/ion-elgreco/delta-rs into fix/merge_special_characters_name_lost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@Blajda I don't think
from_qualified_name_ignore_casewas needed here since the delta_fields don't have relation information, they are just the column names.from_qualified_name_ignore_casewill try to parse__delta_rs_c_y--1and results into__delta_rs_c_y, whilefrom_namejust keeps the column name as-is, which is preferred.Related Issue(s)