-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(python, rust): remove imds calls from profile auth and region #2442
Conversation
…kup when disabled by settings
Hey @mightyshazam, I am seeing also a lot of warnings with our latest release regarding this IMDS region:
Right, so this PR makes it not the default anymore or you still need to manually pass disable_EC2_metadata everytime? (sorry just woke up : ) ) |
This PR means you have to pass it. I am tempted to make disabling ec2 metadata default behavior for the sake of backwards compatibility, though. |
@mightyshazam let's go for putting it disabled by default. Then for EC2 instance users they should enable it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mightyshazam!
Head branch was pushed to by a user without write access
@mightyshazam I checked today, but I am still seeing some warnings. So it seems to be not fully disabled yet?
|
@ion-elgreco I don't see this when running with default settings. I also don't see it when setting |
Only when setting the env variable |
Description
The AWS SDK uses EC2 instance metadata in the default provider chain, the profile chain and the region provider
Related Issue(s)
Documentation