Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: consistently use raise_if_key_not_exists in CreateBuilder #2569

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix: consistently use raise_if_key_not_exists in CreateBuilder #2569

merged 1 commit into from
Jun 4, 2024

Conversation

vegarsti
Copy link
Contributor

@vegarsti vegarsti commented Jun 4, 2024 •
edited
Loading

I forgot to change the name of the builder method!

Follow up from #2565.

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Jun 4, 2024
@vegarsti vegarsti mentioned this pull request Jun 4, 2024
Merged
ion-elgreco
ion-elgreco previously approved these changes Jun 4, 2024
View reviewed changes
@vegarsti
Copy link
Contributor Author

vegarsti commented Jun 4, 2024

Thanks!

@ion-elgreco ion-elgreco enabled auto-merge (squash) June 4, 2024 11:55
@ion-elgreco
Copy link
Collaborator

@vegarsti gotta update it also in python/src/lib : )

auto-merge was automatically disabled June 4, 2024 12:53

Head branch was pushed to by a user without write access

@vegarsti vegarsti requested a review from fvaleye as a code owner June 4, 2024 12:53
@vegarsti
Copy link
Contributor Author

vegarsti commented Jun 4, 2024

Doh! Done, thanks

@github-actions github-actions bot added the binding/python Issues for the Python package label Jun 4, 2024
@ion-elgreco ion-elgreco enabled auto-merge (squash) June 4, 2024 14:38
@ion-elgreco ion-elgreco merged commit 12d498e into delta-io:main Jun 4, 2024
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ion-elgreco ion-elgreco ion-elgreco approved these changes

@wjones127 wjones127 Awaiting requested review from wjones127 wjones127 is a code owner

@roeap roeap Awaiting requested review from roeap roeap is a code owner

@rtyler rtyler Awaiting requested review from rtyler rtyler is a code owner

@fvaleye fvaleye Awaiting requested review from fvaleye fvaleye is a code owner

Assignees
No one assigned
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vegarsti @ion-elgreco