feat(python, rust): cdc write-support for overwrite and replacewhere writes
#2722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion-elgreco
requested review from
wjones127,
fvaleye,
roeap,
rtyler and
hntd187
as code owners
github-actions
bot
added
binding/python
ion-elgreco
changed the title
overwrite and replaceWhere writes overwrite and replacewhere writes
ion-elgreco
changed the title
overwrite and replacewhere writes overwrite and replacewhere writes
ion-elgreco
force-pushed
the
feat/cdc_normal_writes
branch
from
e70942c to
2dd220d
Compare
rtyler
approved these changes
Aug 6, 2024
|
just was looking thorough some of the recent PRs - it seems we did not do any testing for rust in this PR. Should we add an issue for this or did I just miss that? |
|
@roeap might have missed that, but can add them at later! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A normal write with mode "overwrite" or "overwrite" with predicate, will write CDC actions and CDC data now.
This one should be merged first: #2721
Related Issue(s)