feat: use logical plan in update, refactor/simplify CDCTracker #2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion-elgreco
requested review from
wjones127,
fvaleye,
roeap,
rtyler and
hntd187
as code owners
ion-elgreco
force-pushed
the
feat/logical_update
branch
from
80de699 to
0164b29
Compare
github-actions
bot
added
binding/python
|
@rtyler I've re-enabled the Struct support in CDF (update) now that the fix in arrow-rs 52.2 is available. |
rtyler
reviewed
Aug 6, 2024
There was a problem hiding this comment.
Great work @ion-elgreco! I'm doing some local testing with this pull request, and will squash some commits and merge once I'm done
rtyler
force-pushed
the
feat/logical_update
branch
from
47752cb to
da666d9
Compare
rtyler
force-pushed
the
feat/logical_update
branch
from
722b42d to
d8c1e91
Compare
rtyler
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update is now using logical plans, same as CDCTracker.
Can be merged after this: #2725
Issues
closes #2568