-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(python, rust): allow in
pushdowns in early_filter
#2807
fix(python, rust): allow in
pushdowns in early_filter
#2807
Conversation
9531181
to
70d4f92
Compare
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
in
pushdowns in early_filter in
pushdowns in early_filter
@ion-elgreco I pulled this into my CI infrastructure, and also have some bigger tables at |
In the mod.rs are also tests related to the filters, maybe you can move them also to the filter.rs |
Ah yes, missed those :) |
A test with a condition like |
Hmm I will add some more tests, by the way I wonder if we want placeholder exprs if a user already explicitly passed a predicate for that partition column. If I do |
I've put it in draft until I add some more tests in Rust |
The placeholder expr could be more restrictive than the explicit expr. I think performance should not be affected |
Hi! I've added a Rust test that covers above mentiond condition here in this PR. Also added a few more Rust unit tests for |
9cdaf1e
to
b5ecfbc
Compare
I have done some manual testing with this pull request and I can say that at least it did not adversely impact performance 😄 . I will rebase this branch, merge it, and then we can go from there |
b5ecfbc
to
ef9971e
Compare
Description
is_in filters can be used now to do partition pruning, I also moved all the filter logic into it's own module.
Related issues
IN (...)
clauses appear to be ignored in merge commands with S3 - extra partitions scanned #2726