feat: implement stale-while-revalidate for HTTP cache #6337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/http-stale-while-revalidate
branch
from
8c3fc6d to
3a5e3b9
Compare
iequidoo
reviewed
Dec 12, 2024
| // Update expiration timestamp | ||
| // to prevent deletion of the file still in use. | ||
| // | ||
| // We do not update stale timestamp here |
There was a problem hiding this comment.
Still it makes sense to update stale to e.g. now + 1*minute to avoid revalidating very frequently (and have many parallel revalidation tasks) if revalidation fails or the HTTP request takes some time. The stale period is >= 1 hour, so 1 more minute won't be a problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.