Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for wasm32-wasip1 precompiled bindings in rquickjs and remove bindgen feature if supported #2403

Closed
bdemann opened this issue Dec 31, 2024 · 0 comments · Fixed by #2459

Comments

@bdemann
Copy link
Member

bdemann commented Dec 31, 2024

Description

We are currently using the bindgen feature of the rquickjs crate to support the wasm32-wasip1 target. This was necessary because [email protected] does not provide precompiled bindings for the wasm32-wasip1 target.

The wasm32-wasip1 target replaces the wasm32-wasi target, which will be deprecated in Rust's nightly builds in October 2024 and removed from stable Rust in January 2025. Until rquickjs includes precompiled bindings for wasm32-wasip1, the bindgen feature allows us to dynamically generate the necessary bindings.

Action Items

  1. Periodically check new releases of rquickjs for updates to the precompiled bindings.
    • Specifically, verify if the wasm32-wasip1 target is now supported out of the box.
  2. If rquickjs adds precompiled bindings for wasm32-wasip1:
    • Remove the bindgen feature from our Cargo.toml:
      [dependencies]
      rquickjs = { version = "x.y.z", features = ["array-buffer"] }  # Without the `bindgen` feature
    • Test the project to confirm compatibility with the new bindings.

Context

This issue serves as a reminder to revisit this decision and to adopt precompiled bindings when they are available, as they are generally more efficient than using bindgen.

@bdemann bdemann mentioned this issue Dec 31, 2024
7 tasks
@lastmjs lastmjs modified the milestones: 0.25.0, 0.26.0 Jan 1, 2025
@bdemann bdemann linked a pull request Jan 7, 2025 that will close this issue
14 tasks
@bdemann bdemann modified the milestones: 0.26.0, Release Candidate Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants