Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove instructionCounter and fix performanceCounter tests #2459

Merged
merged 2 commits into from
Jan 7, 2025
Merged

remove instructionCounter and fix performanceCounter tests #2459

merged 2 commits into from
Jan 7, 2025

Conversation

lastmjs
Copy link
Member

@lastmjs lastmjs commented Jan 7, 2025 •
edited by bdemann
Loading

Contributor

  • Breaking changes enumerated in the release issue
  • New documentation enumerated in the release issue
  • Code has been declaratized
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • All new functions have JSDoc/Rustdoc comments
  • Related issues have been linked and all tasks have been completed or made into separate issues

Reviewer

  • Breaking changes enumerated in the release issue
  • New documentation enumerated in the release issue
  • Code has been declaratized
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • All new functions have JSDoc/Rustdoc comments
  • Related issues have been linked and all tasks have been completed or made into separate issues

@lastmjs lastmjs marked this pull request as ready for review January 7, 2025 20:46
bdemann
bdemann previously approved these changes Jan 7, 2025
View reviewed changes
@bdemann bdemann linked an issue Jan 7, 2025 that may be closed by this pull request
Check for wasm32-wasip1 precompiled bindings in rquickjs and remove bindgen feature if supported #2403
Closed
@lastmjs lastmjs merged commit 32027e3 into main Jan 7, 2025
367 of 371 checks passed
@lastmjs lastmjs deleted the fix_performance_counter branch January 16, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdemann bdemann bdemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for wasm32-wasip1 precompiled bindings in rquickjs and remove bindgen feature if supported
2 participants
@lastmjs @bdemann