Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub workflows #2031

Merged
merged 114 commits into from
Sep 17, 2024
Merged

Update GitHub workflows #2031

merged 114 commits into from
Sep 17, 2024

Conversation

bdemann
Copy link
Member

@bdemann bdemann commented Aug 29, 2024

  • Make sure this stuff works on a release branch
  • Make sure bash conditionals are correct and using the correct equality operator
  • Update the ids of the final two tests in the yml and update the corresponding ids/names in github
  • Make sure that the release tests test everything using the AZLE_TEST_RUN_ON_RELEASE env var
    • class_syntax/new
    • large_files
      • 250MiB
      • 1 GiB
      • 2 GiB
    • http_server/new
    • Additionally some are filtered entirely if we are on a release
      • examples/basic_bitcoin
      • examples/bitcoin_psbt
      • examples/ckbtc
      • tests/end_to_end/http_server/ethers_base
      • tests/end_to_end/http_server/http_outcall_fetch
      • tests/end_to_end/http_server/ic_evm_rpc
      • tests/property/candid_rpc/class_api/stable_b_tree_map
      • tests/property/candid_rpc/functional_api/stable_b_tree_map
    • My current thought is that these that are filtered we hope to one day run on regular tests but are too flaky. Meanwhile tests like new will only ever run on releases. So those are proper to have filtered in their package.json to denote the permanentality of their skipping except on release, right?

.github/actions/get_test_infos/dir_to_test_info.js Outdated Show resolved Hide resolved
.github/actions/get_test_infos/discover_test_dirs.js Outdated Show resolved Hide resolved
.github/actions/get_test_infos/discover_test_dirs.js Outdated Show resolved Hide resolved
.github/actions/get_test_infos/get_test_infos.js Outdated Show resolved Hide resolved
.github/scripts/install_global_dependencies.sh Outdated Show resolved Hide resolved
src/build/stable/utils/log_global_dependencies.ts Outdated Show resolved Hide resolved
src/build/stable/utils/log_global_dependencies.ts Outdated Show resolved Hide resolved
src/build/stable/utils/log_global_dependencies.ts Outdated Show resolved Hide resolved
.github/actions/get_test_infos/discover_test_dirs.ts Outdated Show resolved Hide resolved
.github/actions/get_test_infos/discover_test_dirs.ts Outdated Show resolved Hide resolved
.github/actions/get_test_infos/discover_test_dirs.ts Outdated Show resolved Hide resolved
.github/actions/get_test_infos/discover_test_dirs.ts Outdated Show resolved Hide resolved
.github/actions/get_test_infos/get_test_infos.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@lastmjs lastmjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The algorithm is broken now for some reason, the algorithm to determine the paths

@lastmjs lastmjs merged commit 5ebdff4 into main Sep 17, 2024
231 of 232 checks passed
@bdemann bdemann deleted the update_github_workflows branch September 20, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants