-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub workflows #2031
Merged
Merged
Update GitHub workflows #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bdemann
commented
Aug 29, 2024
•
edited
Loading
edited
- Make sure this stuff works on a release branch
- Make sure bash conditionals are correct and using the correct equality operator
- Update the ids of the final two tests in the yml and update the corresponding ids/names in github
- Make sure that the release tests test everything using the AZLE_TEST_RUN_ON_RELEASE env var
- class_syntax/new
- large_files
- 250MiB
- 1 GiB
- 2 GiB
- http_server/new
- Additionally some are filtered entirely if we are on a release
- examples/basic_bitcoin
- examples/bitcoin_psbt
- examples/ckbtc
- tests/end_to_end/http_server/ethers_base
- tests/end_to_end/http_server/http_outcall_fetch
- tests/end_to_end/http_server/ic_evm_rpc
- tests/property/candid_rpc/class_api/stable_b_tree_map
- tests/property/candid_rpc/functional_api/stable_b_tree_map
- My current thought is that these that are filtered we hope to one day run on regular tests but are too flaky. Meanwhile tests like new will only ever run on releases. So those are proper to have filtered in their package.json to denote the permanentality of their skipping except on release, right?
lastmjs
requested changes
Sep 13, 2024
lastmjs
requested changes
Sep 17, 2024
lastmjs
approved these changes
Sep 17, 2024
lastmjs
approved these changes
Sep 17, 2024
lastmjs
requested changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The algorithm is broken now for some reason, the algorithm to determine the paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.