demergent-labs · lastmjs · Dec 10, 2024 · Oct 16, 2024 · Oct 16, 2024 · Oct 16, 2024
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -26,6 +26,14 @@ module.exports = {
     },
     plugins: ['@typescript-eslint', 'simple-import-sort'],
     rules: {
+        'no-restricted-syntax': [
+            'error',
+            {
+                selector: "IfStatement[test.type!='BinaryExpression']",
+                message:
+                    'Conditional expressions must use explicit comparisons (e.g., === or !==).'
+            }
+        ],
         'simple-import-sort/exports': 'error',
         'simple-import-sort/imports': 'error',
         'func-style': ['error', 'declaration', { allowArrowFunctions: true }],

diff --git a/benchmark/markdown.ts b/benchmark/markdown.ts
@@ -1661,7 +1661,7 @@ function format_number_to_rust(number: string | number | bigint): string {
         (number_is_negative === false && Number(number) < 1) ||
         (number_is_negative === true && Number(number) > -1);
 
-    if (number_is_decimal_less_than_one) {
+    if (number_is_decimal_less_than_one === true) {
         return number.toString();
     }
 

diff --git a/src/build/experimental/commands/upload_assets/file_uploader/on_before_exit.ts b/src/build/experimental/commands/upload_assets/file_uploader/on_before_exit.ts
@@ -6,7 +6,7 @@ export function onBeforeExit(paths: [Src, Dest][], actor: UploaderActor): void {
     let cleanUpComplete = false;
 
     process.on('beforeExit', async () => {
-        if (cleanUpComplete) {
+        if (cleanUpComplete === true) {
             // If any async behavior happens in 'beforeExit' then 'beforeExit'
             // will run again. This is need to prevent an infinite loop.
             // Once clean up is complete we are ready to exit

diff --git a/src/lib/experimental/candid/serde/decode.ts b/src/lib/experimental/candid/serde/decode.ts
@@ -39,7 +39,7 @@ function decodeSingle(candidType: CandidType, data: ArrayBuffer): any {
     // The candid type was AzleVoid if when converted to an Idl Type it is []
     const candidTypeWasAzleVoid = Array.isArray(idlType);
 
-    if (candidTypeWasAzleVoid) {
+    if (candidTypeWasAzleVoid === true) {
         return undefined;
     }
 

diff --git a/src/lib/experimental/candid/serde/encode.ts b/src/lib/experimental/candid/serde/encode.ts
@@ -40,7 +40,7 @@ function encodeSingle(candidType: CandidType, data: any): Uint8Array {
     // The candid type was AzleVoid if when converted to an Idl Type it is []
     const candidTypeWasAzleVoid = Array.isArray(idlType);
 
-    if (candidTypeWasAzleVoid) {
+    if (candidTypeWasAzleVoid === true) {
         return new Uint8Array(IDL.encode([], []));
     }
 

diff --git a/src/lib/experimental/candid/types/reference/service/canister_function/index.ts b/src/lib/experimental/candid/types/reference/service/canister_function/index.ts
@@ -201,7 +201,7 @@ function serviceCall(
     ) => {
         const encodedArgs = encode(paramCandidTypes, args);
 
-        if (notify) {
+        if (notify === true) {
             return (callFunction as NotifyRawFunction)(
                 canisterId,
                 methodName,

diff --git a/src/lib/experimental/globals.ts b/src/lib/experimental/globals.ts
@@ -123,7 +123,7 @@ if (globalThis._azleInsideCanister === true) {
 
     RegExp.prototype.exec = function (string): RegExpExecArray | null {
         const match = originalExec.call(this, string);
-        if (match) {
+        if (match !== null) {
             RegExp.leftContext = (string ?? '').substring(0, match.index);
         }
         return match;

diff --git a/src/lib/stable/did_file/visitor/visit/service.ts b/src/lib/stable/did_file/visitor/visit/service.ts
@@ -58,7 +58,7 @@ function serviceToCandidString(
         postMethodCandidString
     );
 
-    if (isFirstService) {
+    if (isFirstService === true) {
         return [
             `service: ${canisterParamsString} -> {\n${funcStrings}\n}`,
             candidTypes

diff --git a/src/lib/stable/ic_apis/data_certificate.ts b/src/lib/stable/ic_apis/data_certificate.ts
@@ -1,8 +1,8 @@
 /**
  * When called from a query call, returns the data certificate
  * authenticating `certifiedData` set by this canister. Otherwise returns
- * `None`.
- * @returns the data certificate or None
+ * `undefined`.
+ * @returns the data certificate or undefined
  */
 export function dataCertificate(): Uint8Array | undefined {
     if (

diff --git a/test/index.ts b/test/index.ts
@@ -21,11 +21,11 @@ export function runTests(
     const { shouldRunTests, shouldRunTypeChecks, shouldRecordBenchmarks } =
         processEnvVars();
 
-    if (shouldRunTests) {
+    if (shouldRunTests === true) {
         describe(`tests`, tests);
     }
 
-    if (shouldRunTypeChecks) {
+    if (shouldRunTypeChecks === true) {
         describe(`type checks`, () => {
             it('checks types', () => {
                 try {
@@ -47,7 +47,7 @@ export function runTests(
         });
     }
 
-    if (shouldRecordBenchmarks && canisterNames !== undefined) {
+    if (shouldRecordBenchmarks === true && canisterNames !== undefined) {
         const canisterNamesArray = Array.isArray(canisterNames)
             ? canisterNames
             : [canisterNames];
@@ -154,5 +154,5 @@ function processEnvVars(): {
 }
 
 function shouldRun(envVar: string, hasOnly: boolean): boolean {
-    return hasOnly ? envVar === 'only' : envVar !== 'false';
+    return hasOnly === true ? envVar === 'only' : envVar !== 'false';
 }
diff --git a/test/property/arbitraries/candid/constructed/opt_arb/definition_arb.ts b/test/property/arbitraries/candid/constructed/opt_arb/definition_arb.ts
@@ -128,7 +128,7 @@ function generateVariableAliasDeclarations(
     innerType: CandidDefinition,
     api: Api
 ): string[] {
-    if (useTypeDeclaration) {
+    if (useTypeDeclaration === true) {
         const type =
             api === 'functional'
                 ? []

diff --git a/test/property/arbitraries/candid/constructed/record_arb/definition_arb.ts b/test/property/arbitraries/candid/constructed/record_arb/definition_arb.ts
@@ -110,7 +110,7 @@ function generateVariableAliasDeclarations(
     const fieldVariableAliasDeclarations = fields.flatMap(
         (field): string[] => field[1].candidMeta.variableAliasDeclarations
     );
-    if (useTypeDeclaration) {
+    if (useTypeDeclaration === true) {
         const type =
             api === 'functional'
                 ? []

diff --git a/test/property/arbitraries/candid/constructed/tuple_arb/definition_arb.ts b/test/property/arbitraries/candid/constructed/tuple_arb/definition_arb.ts
@@ -100,7 +100,7 @@ function generateVariableAliasDeclarations(
     const fieldVariableAliasDeclarations = fields.flatMap(
         (field) => field.candidMeta.variableAliasDeclarations
     );
-    if (useTypeDeclaration) {
+    if (useTypeDeclaration === true) {
         const type =
             api === 'functional'
                 ? []

diff --git a/test/property/arbitraries/candid/constructed/variant_arb/definition_arbs.ts b/test/property/arbitraries/candid/constructed/variant_arb/definition_arbs.ts
@@ -186,7 +186,7 @@ function generateVariableAliasDeclarations(
     const fieldVariableAliasDeclarations = fields.flatMap(
         (field): string[] => field[1].candidMeta.variableAliasDeclarations
     );
-    if (useTypeDeclaration) {
+    if (useTypeDeclaration === true) {
         const type =
             api === 'functional'
                 ? []

diff --git a/test/property/arbitraries/candid/constructed/vec_arb/definition_arb.ts b/test/property/arbitraries/candid/constructed/vec_arb/definition_arb.ts
@@ -123,7 +123,7 @@ function generateVariableAliasDeclarations(
     innerType: CandidDefinition,
     api: Api
 ): string[] {
-    if (useTypeDeclaration) {
+    if (useTypeDeclaration === true) {
         const type =
             api === 'functional'
                 ? []

diff --git a/test/property/arbitraries/candid/reference/service_arb/definition_arb.ts b/test/property/arbitraries/candid/reference/service_arb/definition_arb.ts
@@ -111,7 +111,7 @@ function generateVariableAliasDeclarations(
     const serviceMethodTypeAliasDecls = serviceMethods.flatMap(
         (serviceMethod) => serviceMethod.variableAliasDeclarations
     );
-    if (useTypeDeclaration) {
+    if (useTypeDeclaration === true) {
         const type = api === 'functional' ? [] : [`type ${name} = Principal`];
         return [
             ...serviceMethodTypeAliasDecls,

diff --git a/test/property/arbitraries/candid/simple_type_arbs/definition_arb.ts b/test/property/arbitraries/candid/simple_type_arbs/definition_arb.ts
@@ -94,7 +94,7 @@ function generateVariableAliasDeclarations(
     useTypeDeclaration: boolean,
     api: Api
 ): string[] {
-    if (useTypeDeclaration) {
+    if (useTypeDeclaration === true) {
         if (api === 'class') {
             return [
                 `const ${name} = ${toIDL(candidType)};`,

diff --git a/test/property/test/index.ts b/test/property/test/index.ts
@@ -64,7 +64,7 @@ export async function runTests(
                 console.info('\x1b[31m', `${result.Err}`);
                 console.info('\x1b[0m');
 
-                if (exitProcess) {
+                if (exitProcess === true) {
                     process.exit(1);
                 } else {
                     return false;
@@ -78,7 +78,7 @@ export async function runTests(
                 }
                 console.info('\x1b[0m');
 
-                if (exitProcess) {
+                if (exitProcess === true) {
                     process.exit(1);
                 } else {
                     return false;
@@ -95,7 +95,7 @@ export async function runTests(
             );
             console.info('\x1b[0m');
 
-            if (exitProcess) {
+            if (exitProcess === true) {
                 process.exit(1);
             } else {
                 return false;
@@ -148,7 +148,7 @@ export function createSnakeCaseProxy<T extends object>(
                     : camelToSnakeCase(prop as string);
 
             if (typeof (obj as any)[snakeCaseProp] === 'function') {
-                if (async) {
+                if (async === true) {
                     return async (...args: any[]) => {
                         const new_args = args.map((value) => {
                             return convertKeysToSnakeCase(value);