Benchmark analysis #2293
Merged
Benchmark analysis #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bdemann
commented
Dec 2, 2024
•
bdemann
commented
- Breaking changes enumerated in the release issue
- New documentation enumerated in the release issue
- Code has been declaratized
- Error handling beautiful (no unwraps or expects etc)
- Code tested thoroughly (@lastmjs wants to review the final outputs again)
- final output is sorted alphabetically and not in version order.
Closed
1 task
bdemann
force-pushed
the
benchmark_analysis
branch
3 times, most recently
from
018da2e to
63f0cc7
Compare
bdemann
commented
Dec 16, 2024
bdemann
force-pushed
the
benchmark_analysis
branch
from
1e62b4b to
6e17057
Compare
lastmjs
requested changes
Dec 17, 2024
tests/end_to_end/candid_rpc/functional_syntax/stable_structures/benchmarks.md
Outdated
Show resolved
Hide resolved
bdemann
force-pushed
the
benchmark_analysis
branch
from
6e17057 to
ccfbf28
Compare
bdemann
force-pushed
the
benchmark_analysis
branch
from
ccfbf28 to
f2b556a
Compare
lastmjs
requested changes
Dec 17, 2024
lastmjs
previously approved these changes
Dec 18, 2024
lastmjs
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.