-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rc final rundown #2422
Merged
Merged
Rc final rundown #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bdemann
commented
Jan 3, 2025
•
edited by lastmjs
Loading
edited by lastmjs
- Breaking changes enumerated in the release issue
- New documentation enumerated in the release issue
- Code has been declaratized
- Error handling beautiful (no unwraps or expects etc)
- Code tested thoroughly
- All new functions have JSDoc/Rustdoc comments
- Related issues have been linked and all tasks have been completed or made into separate issues
1fbb1a5
to
7e6bfd8
Compare
25 tasks
7e6bfd8
to
032b2ac
Compare
…o rc_final_rundown
25 tasks
lastmjs
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.