Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

completely remove the global index for the canister methods, combine … #2461

Merged
merged 2 commits into from
Jan 7, 2025
Merged

completely remove the global index for the canister methods, combine … #2461

merged 2 commits into from
Jan 7, 2025

Conversation

lastmjs
Copy link
Member

@lastmjs lastmjs commented Jan 7, 2025 •
edited by bdemann
Loading

…callback and MethodMeta reduction for experimental, fix multiple canisters issue in same project

Contributor

  • Breaking changes enumerated in the release issue
  • New documentation enumerated in the release issue
  • Code has been declaratized
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • All new functions have JSDoc/Rustdoc comments
  • Related issues have been linked and all tasks have been completed or made into separate issues

Reviewer

  • Breaking changes enumerated in the release issue
  • New documentation enumerated in the release issue
  • Code has been declaratized
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • All new functions have JSDoc/Rustdoc comments
  • Related issues have been linked and all tasks have been completed or made into separate issues

@lastmjs
completely remove the global index for the canister methods, combine …
e133c0f 
…callback and MethodMeta reduction for experimental, fix multiple canisters issue in same project
@lastmjs lastmjs marked this pull request as ready for review January 7, 2025 23:29
@lastmjs lastmjs merged commit 05297e9 into main Jan 7, 2025
370 checks passed
@lastmjs lastmjs deleted the experimental_globals branch January 16, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdemann bdemann bdemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lastmjs @bdemann