version config validator #4769
Merged
version config validator #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuvHayun
reviewed
Jan 15, 2025
demisto_sdk/commands/validate/validators/VC_validators/VC100_valid_version_config_file.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/VC_validators/VC100_valid_version_config_file.py
Outdated
Show resolved
Hide resolved
version config file
fix typo
thefrieddan1
requested review from
dantavori and
RosenbergYehuda
as code owners
thefrieddan1
requested review from
YuvHayun
and removed request for
dantavori and
RosenbergYehuda
…o-sdk into version_config-validation
|
Changelog(s) in markdown:
|
thefrieddan1
requested review from
samuelFain
and removed request for
YuvHayun
samuelFain
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
It seems all of @YuvHayun's previous comments were addressed so i'm good with this PR.
I'm approving but please have a look at my two comments.
…o-sdk into version_config-validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes: link to issue
Description
Added validations (VC) for a new file: version_config.json