Skip to content

Commit

Permalink
Revert "feat(fmt): sort type-only named import/exports last" (#25705)
Browse files Browse the repository at this point in the history
Reverts #25690

This was not an issue with the ts compiler anymore. Discussion here:
dprint/dprint-plugin-typescript#664 (comment)
  • Loading branch information
dsherret authored Sep 18, 2024
1 parent bed4647 commit 3dd83fd
Show file tree
Hide file tree
Showing 10 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .dprint.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"third_party"
],
"plugins": [
"https://plugins.dprint.dev/typescript-0.92.0.wasm",
"https://plugins.dprint.dev/typescript-0.93.0.wasm",
"https://plugins.dprint.dev/json-0.19.3.wasm",
"https://plugins.dprint.dev/markdown-0.17.8.wasm",
"https://plugins.dprint.dev/toml-0.6.2.wasm",
Expand Down
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ dotenvy = "0.15.7"
dprint-plugin-json = "=0.19.3"
dprint-plugin-jupyter = "=0.1.3"
dprint-plugin-markdown = "=0.17.8"
dprint-plugin-typescript = "=0.92.0"
dprint-plugin-typescript = "=0.93.0"
env_logger = "=0.10.0"
fancy-regex = "=0.10.0"
faster-hex.workspace = true
Expand Down
2 changes: 1 addition & 1 deletion ext/node/polyfills/_fs/_fs_access.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
// deno-lint-ignore-file prefer-primordials

import {
makeCallback,
type CallbackWithError,
makeCallback,
} from "ext:deno_node/_fs/_fs_common.ts";
import { fs } from "ext:deno_node/internal_binding/constants.ts";
import { codeMap } from "ext:deno_node/internal_binding/uv.ts";
Expand Down
2 changes: 1 addition & 1 deletion ext/node/polyfills/_fs/_fs_chown.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
// deno-lint-ignore-file prefer-primordials

import {
makeCallback,
type CallbackWithError,
makeCallback,
} from "ext:deno_node/_fs/_fs_common.ts";
import {
getValidatedPath,
Expand Down
2 changes: 1 addition & 1 deletion ext/node/polyfills/_fs/_fs_lchown.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
// deno-lint-ignore-file prefer-primordials

import {
makeCallback,
type CallbackWithError,
makeCallback,
} from "ext:deno_node/_fs/_fs_common.ts";
import {
getValidatedPath,
Expand Down
4 changes: 2 additions & 2 deletions ext/node/polyfills/child_process.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ import {
ChildProcessOptions,
normalizeSpawnArguments,
setupChannel,
spawnSync as _spawnSync,
stdioStringToArray,
type SpawnOptions,
spawnSync as _spawnSync,
type SpawnSyncOptions,
type SpawnSyncResult,
stdioStringToArray,
} from "ext:deno_node/internal/child_process.ts";
import {
validateAbortSignal,
Expand Down
2 changes: 1 addition & 1 deletion ext/node/polyfills/https.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
} from "node:http";
import { Agent as HttpAgent } from "node:_http_agent";
import { createHttpClient } from "ext:deno_fetch/22_http_client.js";
import { ServerImpl as HttpServer, type ServerHandler } from "node:http";
import { type ServerHandler, ServerImpl as HttpServer } from "node:http";
import { validateObject } from "ext:deno_node/internal/validators.mjs";
import { kEmptyObject } from "ext:deno_node/internal/util.mjs";
import { Buffer } from "node:buffer";
Expand Down
2 changes: 1 addition & 1 deletion tests/testdata/repl/import_type.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { create, type B } from "./subdir/export_types.ts";
import { type B, create } from "./subdir/export_types.ts";

const b: B = create();

Expand Down
2 changes: 1 addition & 1 deletion tests/testdata/run/import_type.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { create, type B } from "../subdir/export_types.ts";
import { type B, create } from "../subdir/export_types.ts";

const b: B = create();

Expand Down

0 comments on commit 3dd83fd

Please sign in to comment.