Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte preview server crashes when running in Deno #26115

Closed
ylor opened this issue Oct 10, 2024 · 3 comments · Fixed by #26339
Closed

Svelte preview server crashes when running in Deno #26115

ylor opened this issue Oct 10, 2024 · 3 comments · Fixed by #26339
Assignees
Labels
bug Something isn't working correctly node compat

Comments

@ylor
Copy link

ylor commented Oct 10, 2024

$ deno --version
deno 2.0.0 (stable, release, aarch64-apple-darwin)
v8 12.9.202.13-rusty
typescript 5.6.2

deno run dev works as expected but when running deno run build && deno run preview it fails with ERR_EMPTY_RESPONSE. Works as expected in both node and bun.

Please let me know if you have any questions or need further info. Thanks to the devs for all their hard work!

Minimal sample repro project: https://github.com/ylor/deno-repro-svelte

@marvinhagemeister
Copy link
Contributor

Can reproduce. These are the full steps:

  1. Clone https://github.com/ylor/deno-repro-svelte
  2. Run deno install --allow-scripts
  3. Run deno run build && deno run preview

@marvinhagemeister marvinhagemeister added bug Something isn't working correctly node compat labels Oct 10, 2024
@sspilleman
Copy link

sspilleman commented Oct 15, 2024

Is this being worked on? I have the feeling the solution is to force "every package" to comply with the "node:" or "npm:" specifiers because deno needs it... It simply doesn't feel like "deno can be used as a drop-in replacement for node/bun" as stated in the "deno 2 release video/notes/etc." ... I'm ok with having issues, no probs at all... I like deno a lot, switched completely from nodejs and never looked back I'm used to having issues with a lot of npm packages, been there, done that.... Just don't state node compat if it requires the node ecosystem to change their code...

Would it be a temp solution to "just" try assuming without specifiers it's either node: or npm: for the time being?

@bartlomieju
Copy link
Member

Yes, we reviewed it today during the meeting and will prioritize fixing Svelte compatibility.

@nathanwhit nathanwhit self-assigned this Oct 15, 2024
bartlomieju pushed a commit that referenced this issue Oct 17, 2024
Fixes #26115.

We weren't normalizing the headers to lower case, so code that attempted
to delete the `Content-Length` header (but used a different case) wasn't
actually removing the header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly node compat
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants