-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elusive TLS Windows issue with binary data (png files) #9692
Comments
probably related to denoland/std#750. Can you reproduce this issue with v1.7.0? (you can downgrade deno by the command |
This was referenced Apr 7, 2021
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this issue
May 10, 2021
…ite half" using tokio::io::split() to allow concurrent Conn#read() and Conn#write() calls without one blocking the other. However, this introduced a bug: outgoing data gets discarded when the TLS stream is gracefully closed, because the read half is closed too early, before all TLS control data has been received. Fixes: denoland#9692 Fixes: denoland#10049 Fixes: denoland#10296 Fixes: denoland/std#750
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this issue
May 10, 2021
denoland#10146) In denoland#9118, TLS streams were split into a "read half" and a "write half" using tokio::io::split() to allow concurrent Conn#read() and Conn#write() calls without one blocking the other. However, this introduced a bug: outgoing data gets discarded when the TLS stream is gracefully closed, because the read half is closed too early, before all TLS control data has been received. Fixes: denoland#9692 Fixes: denoland#10049 Fixes: denoland#10296 Fixes: denoland/std#750
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Okay, this is a very strange issue, so I'm not very sure where to put this. Let's say I have this Deno HTTPS server:
Using the following image file:
I'm on Windows 10.0.19042.804.
(Edit) Deno version:
On Windows, when I request this server from a browser or curl, it seems to only load the first 64KiB and then hang the request:
If I run the same program in Deno in WSL (1) it works completely fine.
Also if I try to set the file to a 2.5MB JS file, it loads the entire file fine on Windows too, and doesn't hang the request, so there seems to be something that ONLY fails for Windows + binary files going on here.
Am I doing something wrong in my code?
The text was updated successfully, but these errors were encountered: