Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/web): handle no arguments in atob #13341

Merged
merged 1 commit into from
Jan 11, 2022
Merged

fix(ext/web): handle no arguments in atob #13341

merged 1 commit into from
Jan 11, 2022

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Jan 11, 2022 •
edited
Loading

WPT tests are pending on getting html idlharness tests running.

Closes #13341

@lucacasonato lucacasonato mentioned this pull request Jan 11, 2022
Closed
crowlKats
crowlKats approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato merged commit f3ece74 into main Jan 11, 2022
@lucacasonato lucacasonato deleted the atob_fix branch January 11, 2022 16:31
crowlKats pushed a commit that referenced this pull request Jan 12, 2022
@lucacasonato @crowlKats
fix(ext/web): handle no arguments in atob (#13341)
7c33e3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats crowlKats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacasonato @crowlKats