chore: align some Web API type definitions to lib.dom.d.ts #15219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the lib.dom.d.ts type definition and the deno type definition seem to be different for some functions.
The difference I've found is whether the URL is taken as a constructor argument.
example:
URL constructor:
deno/cli/dts/lib.dom.d.ts
Lines 14359 to 14361 in 22a4998
deno/ext/url/lib.deno_url.d.ts
Lines 155 to 156 in 22a4998
Request constructor:
deno/cli/dts/lib.dom.d.ts
Lines 11576 to 11578 in 22a4998
deno/ext/fetch/lib.deno_fetch.d.ts
Lines 254 to 255 in 22a4998
Response.redirect:
deno/cli/dts/lib.dom.d.ts
Lines 11627 to 11632 in 22a4998
deno/ext/fetch/lib.deno_fetch.d.ts
Lines 384 to 388 in 22a4998
Websocket constructor:
deno/cli/dts/lib.dom.d.ts
Lines 16581 to 16583 in 22a4998
deno/ext/websocket/lib.deno_websocket.d.ts
Lines 42 to 43 in 22a4998
This PR modifies the deno type definition to match lib.dom.d.ts. (similar to #14113)