-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test): race condition for cancelled tests #15233
Conversation
@dsherret I figured out where the race condition was, it was this code: Line 1157 in fad8d7d
tests yet.
I've moved that behaviour to the receiving side where it belongs. Now it can be reliably checked that the sending code has no dependency on the receiver state. |
@dsherret please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @nayeemrmn!
Not for merging, debugging flaky test on windows fast ciResolves issue in #15231.