Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove DENO_UNSTABLE_NPM_SYNC_DOWNLOAD and custom sync functionality #20504

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Sep 14, 2023

#20488 enables us to remove this functionality. This is better because our test suite is now not testing a separate code path.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@dsherret dsherret enabled auto-merge (squash) September 14, 2023 17:46
@dsherret dsherret merged commit e66d3c2 into denoland:main Sep 14, 2023
12 checks passed
@dsherret dsherret deleted the refactor_remove_sync_code branch September 15, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants